Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ymdk ymd09 keyboard #7831

Merged
merged 9 commits into from
Jan 10, 2020
Merged

added ymdk ymd09 keyboard #7831

merged 9 commits into from
Jan 10, 2020

Conversation

kaeltis
Copy link
Contributor

@kaeltis kaeltis commented Jan 8, 2020

Description

I've added support for the new 9-key "YMD09" keyboard by YMDK
(https://www.aliexpress.com/i/4000510880374.html)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/ymdk/ymd09/config.h Outdated Show resolved Hide resolved
@kaeltis kaeltis requested a review from zvecr January 9, 2020 17:46
@zvecr zvecr added the keyboard label Jan 9, 2020
@drashna drashna requested a review from a team January 9, 2020 20:14
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things

keyboards/ymdk/ymd09/README.md Outdated Show resolved Hide resolved
keyboards/ymdk/ymd09/rules.mk Outdated Show resolved Hide resolved
@kaeltis kaeltis requested a review from zvecr January 10, 2020 10:41
@zvecr zvecr merged commit 7d7bb5b into qmk:master Jan 10, 2020
@zvecr
Copy link
Member

zvecr commented Jan 10, 2020

Thanks!

@kaeltis kaeltis deleted the ymd09 branch January 10, 2020 14:33
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jan 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits)
  [Keyboard] Reviung41: Configurator layout support (qmk#7852)
  [Keyboard] IDB 60: Configurator bugfix (qmk#7851)
  [Keyboard] Add Xiaomi MK02 (qmk#7825)
  Add user keymaps for KBD67MKII/Lily58 (qmk#7671)
  [Keyboard] KPRepublic BM60 RGB (qmk#7842)
  Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868)
  Adi's DZ65RGB layout (qmk#7845)
  yapf and style
  Make the udev rules easier to read and manage
  Fix Pro Micro's and its bootloader's name
  CLI: Rework ModemManager check and add udev check
  [Keyboard] NK65 Refactor (qmk#7862)
  [Keymap] Updated keymaps (qmk#7834)
  [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853)
  added ymdk ymd09 keyboard (qmk#7831)
  [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849)
  [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798)
  Fix a couple of USB VIDs for the API (qmk#7848)
  Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838)
  Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* added ymdk ymd09 keyboard

* lowercase github username

* change rgb keymap to make more sense

* fixed number of LEDs

* remove configuration for non-existant backlight

* use official template and change file permissions

* disable unnecessary nkro

* Apply suggestions from code review

Co-Authored-By: Joel Challis <git@zvecr.com>

* with easy reset via bootmagic lite, remove RESET from layout

Co-authored-by: Joel Challis <git@zvecr.com>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* added ymdk ymd09 keyboard

* lowercase github username

* change rgb keymap to make more sense

* fixed number of LEDs

* remove configuration for non-existant backlight

* use official template and change file permissions

* disable unnecessary nkro

* Apply suggestions from code review

Co-Authored-By: Joel Challis <git@zvecr.com>

* with easy reset via bootmagic lite, remove RESET from layout

Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants