Added workaround for serial.c issue when LTO_ENABLE=yes for the Lily58 #7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is timing sensitive and seems to break with LTO enabled (at least on avr-gcc 8.3.0... it worked on older gcc versions). This is the same workaround as #7558 applied for the Helix.
zvecr
approved these changes
Jan 11, 2020
fauxpark
approved these changes
Jan 12, 2020
|
Thanks! |
nesth
pushed a commit
to nesth/qmk_firmware
that referenced
this pull request
Jan 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits) [Keyboard] Reviung41: Configurator layout support (qmk#7852) [Keyboard] IDB 60: Configurator bugfix (qmk#7851) [Keyboard] Add Xiaomi MK02 (qmk#7825) Add user keymaps for KBD67MKII/Lily58 (qmk#7671) [Keyboard] KPRepublic BM60 RGB (qmk#7842) Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868) Adi's DZ65RGB layout (qmk#7845) yapf and style Make the udev rules easier to read and manage Fix Pro Micro's and its bootloader's name CLI: Rework ModemManager check and add udev check [Keyboard] NK65 Refactor (qmk#7862) [Keymap] Updated keymaps (qmk#7834) [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853) added ymdk ymd09 keyboard (qmk#7831) [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849) [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798) Fix a couple of USB VIDs for the API (qmk#7848) Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838) Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
This code is timing sensitive and seems to break with LTO enabled (at least on avr-gcc 8.3.0... it worked on older gcc versions). This is the same workaround as qmk#7558 applied for the Helix.
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
This code is timing sensitive and seems to break with LTO enabled (at least on avr-gcc 8.3.0... it worked on older gcc versions). This is the same workaround as qmk#7558 applied for the Helix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same workaround as #7558 applied for the Helix.
Description
This code is timing sensitive and seems to break with LTO enabled (at
least on avr-gcc 8.3.0... it worked on older gcc versions). Without this PR applied, Lily58 slave side is totally nonfunctional (no keystrokes register) when using LTO.
Types of Changes
Issues Fixed or Closed by This PR
Checklist