Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix the STM32 dual-bank bootloader stuff. #9738

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 16, 2020

Description

Apparently I hadn't actually updated to the latest copy when I merged. Serves me right for assuming it was unchanged.
Anyways, this swaps things out to jump to bootloader directly when using dual-bank flash -- there's no need to go through the process of resetting the MCU, then charging the capacitor, and resetting the MCU a second time.

This change makes it so that we skip the first reset -- i.e. we only charge the capacitor then issue a system reset.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 16, 2020 13:51
@tzarc tzarc self-assigned this Jul 16, 2020
@tzarc tzarc merged commit 415f088 into qmk:develop Jul 16, 2020
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
@tzarc tzarc deleted the stm32-dual-bank-bootloaders branch September 10, 2020 02:27
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants