Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vision keyboard #9768

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Add Vision keyboard #9768

merged 11 commits into from
Aug 19, 2020

Conversation

satt99
Copy link
Contributor

@satt99 satt99 commented Jul 19, 2020

Description

Adds support for the Vision keyboard and its PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds support for the Vision

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@satt99 satt99 mentioned this pull request Jul 19, 2020
6 tasks
keyboards/satt/vision/bootloader_defs.h Outdated Show resolved Hide resolved
keyboards/satt/vision/readme.md Outdated Show resolved Hide resolved
keyboards/satt/vision/config.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 21, 2020 20:59
@zvecr zvecr added keyboard via Adds via keymap and/or updates keyboard for via support labels Jul 21, 2020
keyboards/satt/vision/config.h Outdated Show resolved Hide resolved
keyboards/satt/vision/rules.mk Outdated Show resolved Hide resolved
satt99 and others added 2 commits July 23, 2020 17:59
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@satt99
Copy link
Contributor Author

satt99 commented Aug 14, 2020

Hi, sorry to bug you guys.
Is there anything more I should do before the merge of this?

@fauxpark fauxpark requested a review from a team August 14, 2020 15:40
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/satt/vision/vision.h Outdated Show resolved Hide resolved
keyboards/satt/vision/info.json Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/vision.h Show resolved Hide resolved
keyboards/satt/vision/vision.c Show resolved Hide resolved
satt99 and others added 2 commits August 19, 2020 12:25
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
keyboards/satt/vision/keymaps/satt/keymap.c Outdated Show resolved Hide resolved
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit e4a0a5f into qmk:master Aug 19, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 20, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (126 commits)
  [Keyboard] AJisai74 (qmk#10021)
  [Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
  [Keymap] update dvorak_42_key keymaps for atreus and ergodox_ez: add VSCode shortcuts (qmk#10054)
  Fix typo in docs/feature_dynamic_macros (qmk#10085)
  [Keymap] VIA keymap for Cannonkeys Ortho60 (qmk#10086)
  [Keymap] xd60:shura30 (qmk#10089)
  Rename keyboards/handwired/zergo/keymap.c to keyboards/handwired/zergo/keymaps/default/keymap.c (qmk#10094)
  [Keymap] added dbroqua keymap for kbdfans/kbd6x (qmk#10072)
  [Keyboard] Vision keyboard by SatT (qmk#9768)
  60_ansi_arrows Community Layout; mrsendyyk keymaps for dz60 and maartenwut/eon65 (qmk#9993)
  [Keyboard] add Xelus Valor (qmk#10079)
  [Keyboard] Add support for keyboard 'Bolt' (qmk#10046)
  [Keymap] update kejadlen keymaps (qmk#9954)
  [Keymap] jotix_ortho_4x12_layout (qmk#10075)
  Changes to thevankeyboards/minivan:king keymap (qmk#10032)
  Refactor Adelais PCB (qmk#10069)
  [Keyboard] NK87 (qmk#9965)
  Update keymap for Keebio/iris4/rev4 (qmk#10062)
  Dawn60 update that breaks travis keyboard builds (qmk#10082)
  add VIA keymap for boardsource/3x4 (qmk#10043)
  ...
@satt99 satt99 deleted the vision-dev branch August 22, 2020 03:04
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* Add vision keyboard

* Remove bootloader_defs.h

* Update keyboards/satt/vision/readme.md

* Change Vendor ID

* Update keyboards/satt/vision/config.h

* Update keyboards/satt/vision/rules.mk

* Fix info.json

* Apply suggestions from code review

* Add license header

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants