Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NK87 #9965

Merged
merged 14 commits into from
Aug 19, 2020
Merged

Add NK87 #9965

merged 14 commits into from
Aug 19, 2020

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Aug 7, 2020

Description

Add new Novelkeys keyboard: NK87

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yiancar yiancar mentioned this pull request Aug 7, 2020
6 tasks
keyboards/nk87/config.h Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/via/readme.html Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/nk87/readme.md Outdated Show resolved Hide resolved
keyboards/nk87/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Aug 8, 2020
@fauxpark fauxpark requested a review from a team August 8, 2020 00:41
yiancar and others added 5 commits August 8, 2020 09:16
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@yiancar
Copy link
Contributor Author

yiancar commented Aug 8, 2020

Cheers @fauxpark. Should be all good now

keyboards/nk87/readme.md Outdated Show resolved Hide resolved
keyboards/nk87/readme.md Outdated Show resolved Hide resolved
keyboards/nk87/readme.md Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/nk87/keymaps/default/readme.md Outdated Show resolved Hide resolved
yiancar and others added 5 commits August 9, 2020 09:30
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@yiancar
Copy link
Contributor Author

yiancar commented Aug 9, 2020

@fauxpark Done:)

@fauxpark fauxpark requested a review from a team August 9, 2020 08:48
@yiancar
Copy link
Contributor Author

yiancar commented Aug 13, 2020

Bump:)

@yiancar
Copy link
Contributor Author

yiancar commented Aug 18, 2020

Conflict resolved, plz merge me

@noroadsleft
Copy link
Member

Conflict resolved, plz merge me

Only because it's actually done. :)

Thanks!

@noroadsleft noroadsleft merged commit 1ff6816 into qmk:master Aug 19, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 20, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (126 commits)
  [Keyboard] AJisai74 (qmk#10021)
  [Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
  [Keymap] update dvorak_42_key keymaps for atreus and ergodox_ez: add VSCode shortcuts (qmk#10054)
  Fix typo in docs/feature_dynamic_macros (qmk#10085)
  [Keymap] VIA keymap for Cannonkeys Ortho60 (qmk#10086)
  [Keymap] xd60:shura30 (qmk#10089)
  Rename keyboards/handwired/zergo/keymap.c to keyboards/handwired/zergo/keymaps/default/keymap.c (qmk#10094)
  [Keymap] added dbroqua keymap for kbdfans/kbd6x (qmk#10072)
  [Keyboard] Vision keyboard by SatT (qmk#9768)
  60_ansi_arrows Community Layout; mrsendyyk keymaps for dz60 and maartenwut/eon65 (qmk#9993)
  [Keyboard] add Xelus Valor (qmk#10079)
  [Keyboard] Add support for keyboard 'Bolt' (qmk#10046)
  [Keymap] update kejadlen keymaps (qmk#9954)
  [Keymap] jotix_ortho_4x12_layout (qmk#10075)
  Changes to thevankeyboards/minivan:king keymap (qmk#10032)
  Refactor Adelais PCB (qmk#10069)
  [Keyboard] NK87 (qmk#9965)
  Update keymap for Keebio/iris4/rev4 (qmk#10062)
  Dawn60 update that breaks travis keyboard builds (qmk#10082)
  add VIA keymap for boardsource/3x4 (qmk#10043)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* Initial commit

* Fix1

* Final Prettify

* Update keyboards/nk87/config.h

* Update keyboards/nk87/keymaps/default/keymap.c

* Update keyboards/nk87/keymaps/via/keymap.c

* Update keyboards/nk87/rules.mk

* Remove unnecessary junk

* Update keyboards/nk87/readme.md

* Update keyboards/nk87/readme.md

* Update keyboards/nk87/readme.md

* Update keyboards/nk87/keymaps/default/readme.md

* Update keyboards/nk87/keymaps/via/readme.md
@yiancar yiancar deleted the nk87 branch October 1, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants