Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix !(A && B) conditions #115

Closed
quasilyte opened this issue Oct 31, 2020 · 0 comments · Fixed by #142
Closed

Fix !(A && B) conditions #115

quasilyte opened this issue Oct 31, 2020 · 0 comments · Fixed by #142

Comments

@quasilyte
Copy link
Owner

The !(A && B) condition is interpreted as !A && !B; this is incorrect.

This issue should become irrelevant after the refactoring is complete.
It should also become easier to add || operator at that point.
quasilyte added a commit that referenced this issue Dec 20, 2020
@quasilyte
ruleguard: filter parsing improvements
b787354 
Refactored Where() filter parsing code.

Implemented || operator while at it.

Fixes #115 !(A && B) conditions now work properly
Fixes #26  A || B    conditions are now implemented
@quasilyte quasilyte mentioned this issue Dec 20, 2020
Merged
quasilyte added a commit that referenced this issue Dec 20, 2020
@quasilyte
ruleguard: filter parsing improvements
6b935e7 
Refactored Where() filter parsing code.

Implemented || operator while at it.

Fixes #115 !(A && B) conditions now work properly
Fixes #26  A || B    conditions are now implemented
quasilyte added a commit that referenced this issue Dec 20, 2020
@quasilyte
ruleguard: filter parsing improvements
6ca28d1 
Refactored Where() filter parsing code.

Implemented || operator while at it.

Fixes #115 !(A && B) conditions now work properly
Fixes #26  A || B    conditions are now implemented
quasilyte added a commit that referenced this issue Dec 20, 2020
@quasilyte
ruleguard: filter parsing improvements (#142)
0983a9e 
Refactored Where() filter parsing code.

Implemented || operator while at it.

Fixes #115 !(A && B) conditions now work properly
Fixes #26  A || B    conditions are now implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ruleguard: filter parsing improvements quasilyte/go-ruleguard
1 participant
@quasilyte