ruleguard: consider || operator support in Where cond

[quasilyte]

Needed for context-keys-type checker implementation.

m.Match(`context.WithValue($_, $k, $_)`).
	Where(m["k"].Type.Is("bool") ||
		m["k"].Type.Is("int") ||
		m["k"].Type.Is("int8") ||
		m["k"].Type.Is("int16") ||
		m["k"].Type.Is("int32") ||
		m["k"].Type.Is("int64") ||
		m["k"].Type.Is("uint") ||
		m["k"].Type.Is("uint8") ||
		m["k"].Type.Is("uint16") ||
		m["k"].Type.Is("uint32") ||
		m["k"].Type.Is("uint64") ||
		m["k"].Type.Is("uintptr") ||
		m["k"].Type.Is("float32") ||
		m["k"].Type.Is("float64") ||
		m["k"].Type.Is("complex64") ||
		m["k"].Type.Is("complex128") ||
		m["k"].Type.Is("string")).
	Report(`should not use basic type as key in context.WithValue`)

Or maybe we need to add "basic" type predicate for now.

[lamg]

Also makes sense to add support for the rest of boolean operators.

[quasilyte]

I think it's not hard to add new operators, but it's better to have some usage examples before we implement them. :)

[lamg]

Actually I think the only one I really miss is ||. I thought && wasn't fully supported because a parenthesized expression with it inside wasn't recognized.

[quasilyte]

Could you show your || example?

In my original example, the code would be better with Type.IsBasic() which will be faster (no need to apply N conditions).

[dgryski]

I know I have rules in my semgrep-go/ruleguard.rules.go file that could be considerably cleaned up using ||