Add more use of CancellationToken in Async methods. #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1420-cancellationtoken-review
branch
2 times, most recently
from
5421696
to
84cd1cf
Compare
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1420-cancellationtoken-review
branch
from
ca7854e
to
960fd68
Compare
* Correctly dispose of `CancellationTokenSource` and `CancellationTokenRegistration` instances. * Refactor `Connection.Close` to use async internally. * Fix test by adding `WaitAsync` that also takes a timeout. * Add `ConfigureAwait` where it was missing. * Always create `CancellationTokenSource` for recovery, and dispose it. * Modify `WaitAsync` `Task` extension to see if `Task` has already completed. * Don't swallow exceptions unless `abort` is specified. * Add `TaskCreationOptions` to two spots. * Add `SetSessionClosingAsync` * Use `CancellationToken` to stop receieve loop. * Pass the main loop `CancellationToken` into `HardProtocolExceptionHandlerAsync`. * Pass `CancellationToken` to `IFrameHandler.CloseAsync`. * Remove remaining usage of `ThreadPool`
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1420-cancellationtoken-review
branch
from
960fd68
to
035bb90
Compare
lukebakken
deleted the
rabbitmq-dotnet-client-1420-cancellationtoken-review
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1420