Update rustc-ap-syntax from 306.0.0 to 366.0.0 #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-michael
commented
Feb 11, 2019
| @@ -159,6 +160,8 @@ impl Ty { | |||
| }, | |||
| LitKind::FloatUnsuffixed(_) => make_match(PrimKind::F32), | |||
| LitKind::Bool(_) => make_match(PrimKind::Bool), | |||
| // TODO: support err | |||
| LitKind::Err(_) => None, | |||
There was a problem hiding this comment.
The new kind added with this PR.
There was a problem hiding this comment.
We don't have no item to complete for bad literals like 'aaa', so I don't think we need TODO comment here.
|
Thanks 😉 |
|
@kngwyu Thank you for your quick reply. I've fixed and push :) |
|
Thanks again 👍 |
|
Uploaded 2.1.18 now |
|
@kngwyu Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustfmt use v366.0.0.
So if we use same version of rustc-ap-syntax, we can't update rust submodule.
related with: #58356
@kngwyu
After merge this, would you release new racer version?