Implement new literal type Err
#57651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Hmm, the test failed. I'll fix it. |
This comment has been minimized.
This comment has been minimized.
estebank
requested changes
Jan 16, 2019
estebank
reviewed
Jan 17, 2019
estebank
added
S-waiting-on-author
|
@estebank I posted some WIP commits, please review. |
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Jan 19, 2019
estebank
reviewed
Jan 19, 2019
src/libsyntax/parse/lexer/mod.rs
Outdated
| String::from("character literal may only contain one codepoint")).raise(); | ||
| self.err_span_(start_with_quote, pos, | ||
| "character literal may only contain one codepoint"); | ||
| self.bump(); |
There was a problem hiding this comment.
This bump also looks suspect. I'm trying a change locally, but I believe there's a high likelihood that removing this self.bump() will fix the problem with let x = 'asdf //~^ ERROR '.
There was a problem hiding this comment.
Ok, upon further review, just revert this one change and let's fatally fail on this case. The code is beyond meaninful recovery at this point. We'll keep the current behavior for unterminated char literals, but recover in all other cases.
There was a problem hiding this comment.
@JohnTitor I believe that with these changes we'll be as close as we can get quickly to the "ideal" output:
There was a problem hiding this comment.
I'm grateful for your support! Following your commit, I added some commits.
|
@bors r+ |
|
📌 Commit 4005d3a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 21, 2019
Changes: ```` Fixing typo in CONTRIBUTING.md Fix breakage due to rust-lang#57651 Run rustfmt Fixed breakage due to rust-lang#57489 Fix breakage due to rust-lang#57755 Catch up with `format_args` change Fix bad `while_let_on_iterator` suggestion. rustup rust-lang#57747 Fixing issues pointed out by dogfood tests. Update to collect all the files then throw the error. Adding a test for checking if test files are missing. Remove bors.toml add applicability to lint name suggestion ````
Arkweid
pushed a commit
to Arkweid/rust-clippy
that referenced
this pull request
Jan 23, 2019
* master: (58 commits) Rustfmt all the things Don't make decisions on values that don't represent the decision Improving comments. Rustup Added rustfix to the test. Improve span shortening. Added "make_return" and "blockify" convenience methods in Sugg and used them in "needless_bool". Actually check for constants. Fixed potential mistakes with nesting. Added tests. formatting fix Update clippy_lints/src/needless_bool.rs formatting fix Fixing typo in CONTRIBUTING.md Fix breakage due to rust-lang/rust#57651 needless bool lint suggestion is wrapped in brackets if it is an "else" clause of an "if-else" statement Fix automatic suggestion on `use_self`. Remove negative integer literal checks. Fix `implicit_return` false positives. Run rustfmt Fixed breakage due to rust-lang/rust#57489 ...
VardhanThigle
pushed a commit
to jethrogb/rust
that referenced
this pull request
Jan 31, 2019
Changes: ```` Fixing typo in CONTRIBUTING.md Fix breakage due to rust-lang#57651 Run rustfmt Fixed breakage due to rust-lang#57489 Fix breakage due to rust-lang#57755 Catch up with `format_args` change Fix bad `while_let_on_iterator` suggestion. rustup rust-lang#57747 Fixing issues pointed out by dogfood tests. Update to collect all the files then throw the error. Adding a test for checking if test files are missing. Remove bors.toml add applicability to lint name suggestion ````
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` Fixing typo in CONTRIBUTING.md Fix breakage due to rust-lang/rust#57651 Run rustfmt Fixed breakage due to rust-lang/rust#57489 Fix breakage due to rust-lang/rust#57755 Catch up with `format_args` change Fix bad `while_let_on_iterator` suggestion. rustup rust-lang/rust#57747 Fixing issues pointed out by dogfood tests. Update to collect all the files then throw the error. Adding a test for checking if test files are missing. Remove bors.toml add applicability to lint name suggestion ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57384
I removed
return Ok, otherwise, two errors occur. Any solutions?r? @estebank