Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump iOS target to iOS 13 and remove version checks #4327

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Bump iOS target to iOS 13 and remove version checks #4327

merged 3 commits into from
Nov 7, 2022

Conversation

jkadamczyk
Copy link
Contributor

@jkadamczyk jkadamczyk commented Oct 20, 2022 •
edited
Loading

Fixes APP-76

What changed (plus any additional context for devs)

  • Bumped iOS Deployment target from 11 to 13 on all Xcode Targets
  • Removed isNativeStackAvailable variable and removed its usages or replaced it with IS_IOS
  • Removed @available(iOS 13.0) checks in native iOS code (we always have minimum iOS 13 now so it's not needed)

Final checklist

  • Assigned individual reviewers?
  • Did you test both iOS and Android?
  • If your changes are visual, did you check both the light and dark themes?
  • Added e2e tests? If not, please specify why
  • If you added new critical path files, did you update the CODEOWNERS file?

@linear
Copy link

linear bot commented Oct 20, 2022

APP-76 Bump iOS target to version 13 and get rid of `isNativeStackAvailable` checks

Description

  • Only 0.6% of users use our app on versions lower than iOS 13
  • We are not doing QA nor running e2e on iOS below 13
  • By getting rid of the code and old devices we will have a cleaner codebase

Testing Instructions

  • TBD

@jkadamczyk jkadamczyk marked this pull request as ready for review October 21, 2022 19:21
@jkadamczyk jkadamczyk marked this pull request as draft October 23, 2022 23:25
skylarbarrera
skylarbarrera approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@jkadamczyk
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the @jkadamczyk/bump-target-to-ios-13 branch from f17524a to 5481d40 Compare October 24, 2022 18:03
@jkadamczyk jkadamczyk closed this Oct 25, 2022
@jkadamczyk jkadamczyk reopened this Oct 25, 2022
@jkadamczyk jkadamczyk marked this pull request as ready for review October 27, 2022 09:29
@jkadamczyk jkadamczyk force-pushed the @jkadamczyk/bump-target-to-ios-13 branch from 5481d40 to 48278b7 Compare October 27, 2022 09:29
skylarbarrera
skylarbarrera approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good and straightforward, ran a mild QA on the impacted sections and things are looking good 👌

@jkadamczyk
Copy link
Contributor Author

/testflight

@jkadamczyk jkadamczyk force-pushed the @jkadamczyk/bump-target-to-ios-13 branch from d97996c to 4138359 Compare November 4, 2022 13:22
@jkadamczyk
Copy link
Contributor Author

/testflight

@jkadamczyk jkadamczyk merged commit e034342 into develop Nov 7, 2022
@jkadamczyk jkadamczyk deleted the @jkadamczyk/bump-target-to-ios-13 branch November 7, 2022 14:29
estrattonbailey added a commit that referenced this pull request Nov 7, 2022
@estrattonbailey
Merge remote-tracking branch 'origin/develop' into eric/app-79-notifi…
8124c1e 
…cations-onboarding-improvements

* origin/develop:
  version bump (#4364)
  fix: remove persistent image cache (#4354)
  Bump iOS target to iOS 13 and remove version checks (#4327)
  rm log (#4359)
  feat: analytics docs, simplify events (#4356)
  Remove Discover Sheet (#4337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey approved these changes

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@benisgold benisgold Awaiting requested review from benisgold

@salman-rb salman-rb Awaiting requested review from salman-rb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkadamczyk @estrattonbailey @skylarbarrera