Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: analytics docs, simplify events #4356

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

estrattonbailey
Copy link
Contributor

@estrattonbailey estrattonbailey commented Nov 1, 2022

Fixes APP-122

What changed (plus any additional context for devs)

Consolidates event enums and replaces usages. Add usage docs.

Copied from docs:

import { analyticsV2 } from '@/analytics';

analyticsV2.identify({
    ...userProperties,
})

analyticsV2.track(analyticsV2.event.applicationDidMount)
analyticsV2.track(analyticsV2.event.appStateChange, {
    category: 'app state',
    label: 'foo',
})

analyticsV2.screen(Routes.SWAPS_PROMO_SHEET, {
    ...metadata,
})

What to test

Tests pass, app runs.

Copy link
Contributor

@jkadamczyk jkadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@estrattonbailey
Copy link
Contributor Author

/rebase

@estrattonbailey estrattonbailey merged commit 19fb4f8 into develop Nov 3, 2022
@estrattonbailey estrattonbailey deleted the eric/analytics-docs branch November 3, 2022 15:16
estrattonbailey added a commit that referenced this pull request Nov 7, 2022
…cations-onboarding-improvements

* origin/develop:
  version bump (#4364)
  fix: remove persistent image cache (#4354)
  Bump iOS target to iOS 13 and remove version checks (#4327)
  rm log (#4359)
  feat: analytics docs, simplify events (#4356)
  Remove Discover Sheet (#4337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants