Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Make experimental/read_json.hpp the default JSON reading engine #11982

Closed
GregoryKimball opened this issue Oct 25, 2022 · 2 comments · Fixed by #13757
Closed

[FEA] Make experimental/read_json.hpp the default JSON reading engine #11982

GregoryKimball opened this issue Oct 25, 2022 · 2 comments · Fixed by #13757
Assignees
@karthikeyann @galipremsagar
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Milestone
Nested JSON reader

Comments

@GregoryKimball
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Let's make engine='cudf_experimental' the default JSON reader.

Describe the solution you'd like

  1. refactor cuDF's read_json to use the nested JSON reader by default
  2. refactor libcudf to promote the experimental JSON reader
  3. refactor libcudf to begin deprecating the legacy JSON reader

Describe alternatives you've considered
n/a

Additional context
Please review the nested JSON reader milestone
@GregoryKimball GregoryKimball added feature request New feature or request Needs Triage Need team to review and classify labels Oct 25, 2022
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Oct 25, 2022
@GregoryKimball GregoryKimball added this to the Nested JSON reader milestone Oct 25, 2022
@GregoryKimball GregoryKimball mentioned this issue Oct 25, 2022
Closed
@GregoryKimball GregoryKimball mentioned this issue Dec 1, 2022
Closed
@vuule
Copy link
Contributor

vuule commented Mar 14, 2023

What is left to do here? IIRC, just internal code reorg to match the new default (namespace shuffle). is that correct?

@karthikeyann
Copy link
Contributor

Correct.

@GregoryKimball GregoryKimball added the libcudf Affects libcudf (C++/CUDA) code. label Apr 2, 2023
@vuule vuule mentioned this issue Jul 31, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 3, 2023
@vuule
Restructure JSON code to correctly reflect legacy/experimental status (…
dcc8d91 
…#13757)

Closes #11982

Moved files to correct directories.
Updated namespaces: experimental -> base, base -> legacy
Improved namespace nesting to reduce the need for fully qualified names (`json::detail` instead of `detail::json`).
Use `host_span` instead of `std::vector &` in all `read_json` variants.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Nghia Truong (https://github.com/ttnghia)

URL: #13757
@bdice bdice mentioned this issue Apr 15, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikeyann karthikeyann

@galipremsagar galipremsagar

Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
Nested JSON reader
Development

Successfully merging a pull request may close this issue.

Restructure JSON code to correctly reflect legacy/experimental status vuule/cudf
4 participants
@karthikeyann @galipremsagar @GregoryKimball @vuule