[FEA] Remove legacy JSON reader #15537
Comments
|
I feel confident about (1) and will open a PR. @vuule -- can you weigh in on the rest of the plan here? |
|
sounds good. Only one thing - we can move the new reader out of experimental earlier. IIRC this is something we missed when we switched the default reader. |
|
Apparently this was already done. Task removed. |
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 16, 2024
This PR removes the `engine="cudf_legacy"` option from Python. This is a part of #15537. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15538
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 17, 2024
This PR deprecates the option for using the legacy JSON reader, so it can be removed in the next RAPIDS release. This work follows up on a task from #15537 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Vukasin Milovanovic (https://github.com/vuule) URL: #15558
This was referenced Apr 18, 2024
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 19, 2024
This PR renames the "experimental" JSON reader tests. These are now production grade and not experimental. This task is tracked in #15537. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) URL: #15568
rapids-bot bot
pushed a commit
that referenced
this issue
May 6, 2024
This PR addresses a task from #15537 to remove the `host_parse_nested_json` code path and corresponding tests. See discussion in #15568 (comment). Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Mark Harris (https://github.com/harrism) URL: #15674
3 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
May 23, 2024
This completes the final two steps and closes #15537. Also addresses one step of #12261. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - David Wendt (https://github.com/davidwendt) - Shruti Shivakumar (https://github.com/shrshi) - Matthew Roeschke (https://github.com/mroeschke) URL: #15813
3 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Jul 2, 2024
Follow-up for #15537 and #15813 to remove some missed code. Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) URL: #16135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The legacy JSON reader has been replaced by an "experimental" JSON reader. The experimental reader has been in production use for over a year, so we'd like to remove the legacy code.
Python's options for using the legacy reader in
cudf.read_jsonhave been deprecated since 23.02 and we use the "experimental" (non-legacy) reader by default in C++ (#11982). I'll file an issue describing how we can remove this in parts:host_parse_nested_json:concurrent_unordered_map. libcudf's copy of this code is used in legacy JSON reader, which might be the last remaining usage. All others have been migrated to use cuCollections. See [FEA] Refactor hash-based algorithms with new cuco data structures #12261The text was updated successfully, but these errors were encountered: