Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add column_device_view to ORC reader and writer structures #7334

Closed
3 of 4 tasks
kaatish opened this issue Feb 5, 2021 · 2 comments
Closed
3 of 4 tasks

[FEA] Add column_device_view to ORC reader and writer structures #7334

kaatish opened this issue Feb 5, 2021 · 2 comments
Assignees
@kaatish
Labels
cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@kaatish
Copy link
Contributor

kaatish commented Feb 5, 2021 •
edited
Loading

In ORC reader and writer the following structures contain members which recreate information that can be stored using column_device_view :

  • EncChunk
  • DictionaryChunk
  • StripeDictionary
  • ColumnDesc

These structures should be refactored to replace these members by column_device_view wherever possible.
@kaatish kaatish added Needs Triage Need team to review and classify feature request New feature or request labels Feb 5, 2021
@vuule vuule added cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. tech debt and removed Needs Triage Need team to review and classify feature request New feature or request labels Feb 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

This was referenced Mar 17, 2021
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 25, 2021
@kaatish
Add column_device_view to orc writer (#7676)
f1f1d0f 
This PR adds column_device_view members to EncChunk, DictionaryChunk and StripeDictionary structures which are used in the ORC writer. The idea is to replace members in these structures which replicate the same information. Usage of nvstrdesc_s has also been eliminated in the ORC writer.

Fixes #7347, Addresses #5682, Addresses #7334

Authors:
  - Kumar Aatish (@kaatish)

Approvers:
  - Vukasin Milovanovic (@vuule)
  - Devavret Makkar (@devavret)

URL: #7676
@kaatish
Copy link
Contributor Author

kaatish commented Apr 7, 2021

The three structures EncChunk, DictionaryChunk and StripeDictionary have been refactored are required.

ColumnDesc however should not be changed because the readers use column_buffer to allocate memory instead of column and therefore mutable_column_device_view cannot be utilized in that case.

@kaatish kaatish closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaatish kaatish

Labels
cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaatish @vuule