Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refactor stats_column_desc in cuio #7347

Closed
kaatish opened this issue Feb 9, 2021 · 3 comments · Fixed by #7676
Closed

[FEA] Refactor stats_column_desc in cuio #7347

kaatish opened this issue Feb 9, 2021 · 3 comments · Fixed by #7676
Assignees
@kaatish
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@kaatish
Copy link
Contributor

kaatish commented Feb 9, 2021 •
edited
Loading

The stats_column_desc structure contains multiple members such as valid_map_base, column_offset, column_data_base etc. that can replaced by column_device_view.

Doing so will require changing other functions accordingly such as GatherColumnStatistics, MergeColumnStatistics used for stats calculation.
@kaatish kaatish added feature request New feature or request Needs Triage Need team to review and classify labels Feb 9, 2021
@kaatish kaatish self-assigned this Feb 9, 2021
@kaatish kaatish added cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. tech debt labels Feb 9, 2021
@kaatish kaatish removed the Needs Triage Need team to review and classify label Feb 9, 2021
@kaatish kaatish mentioned this issue Feb 24, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 6, 2021
@kaatish
Statistics cleanup (#7439)
ab7fe05 
Addresses #7347

Authors:
  - Kumar Aatish (@kaatish)

Approvers:
  - David (@davidwendt)
  - Devavret Makkar (@devavret)
  - Vukasin Milovanovic (@vuule)

URL: #7439
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@devavret
Copy link
Contributor

@kaatish Does #7439 completely address this?

@kaatish
Copy link
Contributor Author

kaatish commented Mar 17, 2021

@kaatish Does #7439 completely address this?

No it does not. I am currently working on #7334 which should enable me to finish this.

@kaatish kaatish mentioned this issue Mar 23, 2021
Merged
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this issue Mar 25, 2021
@kaatish @hyperbolic2346
Statistics cleanup (rapidsai#7439)
6f6b5ab 
Addresses rapidsai#7347

Authors:
  - Kumar Aatish (@kaatish)

Approvers:
  - David (@davidwendt)
  - Devavret Makkar (@devavret)
  - Vukasin Milovanovic (@vuule)

URL: rapidsai#7439
rapids-bot bot pushed a commit that referenced this issue Mar 25, 2021
@kaatish
Add column_device_view to orc writer (#7676)
f1f1d0f 
This PR adds column_device_view members to EncChunk, DictionaryChunk and StripeDictionary structures which are used in the ORC writer. The idea is to replace members in these structures which replicate the same information. Usage of nvstrdesc_s has also been eliminated in the ORC writer.

Fixes #7347, Addresses #5682, Addresses #7334

Authors:
  - Kumar Aatish (@kaatish)

Approvers:
  - Vukasin Milovanovic (@vuule)
  - Devavret Makkar (@devavret)

URL: #7676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaatish kaatish

Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add column_device_view to orc writer
2 participants
@kaatish @devavret