You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
VibhuJawa
changed the title
[BUG]cudf.get_dummies fails if dollar symbol is present in data
[BUG]cudf.get_dummies fails if symbols ( $,( ) are present in data
Jul 22, 2021
Fixes: #8832
This PR fixes `contains` check in the `StringColumn`. We were using `f"^{item}$"` to generate a regex and do a `contains_re` to check for an exact match for `item` in the `StringColumn`, but this approach would break if `item` by itself has some regex special characters, so replaced these checks with `libcudf.search.contains` which does the exact check for `item` in the `StringColumn`.
Authors:
- GALI PREM SAGAR (https://github.com/galipremsagar)
Approvers:
- Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)
- Charles Blackmon-Luca (https://github.com/charlesbluca)
URL: #8834
Describe the bug
cudf.get_dummies fails if dollar symbol is present in data
Steps/Code to reproduce bug
Expected behavior
I would expect it to work.
Additional context
Looking at the trace it seems like we are not handling regex correctly at line here:
The text was updated successfully, but these errors were encountered: