[REVIEW] Fix contains
check in string column
#8834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8832
This PR fixes
contains
check in theStringColumn
. We were usingf"^{item}$"
to generate a regex and do acontains_re
to check for an exact match foritem
in theStringColumn
, but this approach would break ifitem
by itself has some regex special characters, so replaced these checks withlibcudf.search.contains
which does the exact check foritem
in theStringColumn
.