Allow initial value for cudf::reduce and cudf::segmented_reduce. #11137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrikarVanavasam
added
3 - Ready for Review
SrikarVanavasam
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11137 +/- ##
===============================================
Coverage ? 86.31%
===============================================
Files ? 144
Lines ? 22748
Branches ? 0
===============================================
Hits ? 19636
Misses ? 3112
Partials ? 0 Continue to review full report at Codecov.
|
|
Pinging @bdice |
bdice
reviewed
Jun 23, 2022
bdice
reviewed
Jun 23, 2022
| @@ -93,13 +99,15 @@ std::unique_ptr<scalar> max( | |||
| * | |||
| * @param col input column to compute any_of. | |||
| * @param output_dtype data type of return type and typecast elements of input column | |||
| * @param init initial value of the any | |||
There was a problem hiding this comment.
At some later time, we might consider short-circuiting execution for any/all if the initial value is true/false, respectively. No need to look at the data -- but that might be a premature optimization at this point.
bdice
reviewed
Jun 28, 2022
bdice
reviewed
Jun 29, 2022
ttnghia
reviewed
Jul 1, 2022
ttnghia
reviewed
Jul 6, 2022
ttnghia
reviewed
Jul 8, 2022
ttnghia
reviewed
Jul 8, 2022
ttnghia
reviewed
Jul 8, 2022
ttnghia
approved these changes
Jul 8, 2022
hyperbolic2346
approved these changes
Jul 12, 2022
mythrocks
approved these changes
Jul 13, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
The recently merged PR (#11137) did not include the `<optional>` header which may cause compile error in some systems (in particular, CUDA 11.7 + gcc-11.2): ``` error: ‘std::optional’ has not been declared error: ‘optional’ in namespace ‘std’ does not name a template type ``` This PR adds that missing header to fix the compile issue. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Gera Shegalov (https://github.com/gerashegalov) - David Wendt (https://github.com/davidwendt) - Mike Wilson (https://github.com/hyperbolic2346) URL: #11257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11002
Previously, the algorithms cudf::reduce and cudf::segmented_reduce did not accept an initial value. This PR overloads of the algorithms that do accept an initial value. Initial values are not yet supported for segmented string reductions and can be addressed in a second PR