Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error due to missing header #11257

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jul 13, 2022

The recently merged PR (#11137) did not include the <optional> header which may cause compile error in some systems (in particular, CUDA 11.7 + gcc-11.2):

error: ‘std::optional’ has not been declared
error: ‘optional’ in namespace ‘std’ does not name a template type

This PR adds that missing header to fix the compile issue.

@ttnghia ttnghia added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 13, 2022
@ttnghia ttnghia self-assigned this Jul 13, 2022
@ttnghia ttnghia requested a review from a team as a code owner July 13, 2022 18:20
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@62c0ae8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11257   +/-   ##
===============================================
  Coverage                ?   86.31%           
===============================================
  Files                   ?      144           
  Lines                   ?    22748           
  Branches                ?        0           
===============================================
  Hits                    ?    19636           
  Misses                  ?     3112           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c0ae8...b0d1747. Read the comment docs.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 833cadd into rapidsai:branch-22.08 Jul 13, 2022
@ttnghia ttnghia deleted the fix_compile_errors branch July 28, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants