Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to nvCOMP 3.0.4 #13815

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Upgrade to nvCOMP 3.0.4 #13815

merged 12 commits into from
Nov 10, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 3, 2023 •
edited
Loading

Description

Update the nvCOMP version used for cuIO compression/decompression to 3.0.4.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added feature request New feature or request non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details labels Aug 3, 2023
@robertmaynard robertmaynard mentioned this pull request Aug 3, 2023
Merged
7 tasks
@vuule vuule changed the title TEST update to nvcomp 3.0.0 TEST update to nvcomp 3.0.1 Aug 10, 2023
@vuule vuule changed the title TEST update to nvcomp 3.0.1 TEST update to nvcomp 3.0.2 Aug 28, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vuule vuule changed the base branch from branch-23.10 to branch-23.12 September 22, 2023 16:24
@vuule vuule changed the title TEST update to nvcomp 3.0.2 TEST update to nvcomp 3.0.3 Oct 9, 2023
@jbrennan333 jbrennan333 mentioned this pull request Oct 17, 2023
Closed
@vuule vuule changed the title TEST update to nvcomp 3.0.3 TEST update to nvcomp 3.0.4 Oct 31, 2023
@vuule
Copy link
Contributor Author

vuule commented Oct 31, 2023

/ok to test

bdice
bdice reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update these files before merging:

Also remove "TEST" From the PR title.

@github-actions github-actions bot added the conda label Nov 2, 2023
@vuule vuule changed the title TEST update to nvcomp 3.0.4 Upgrade to nvCOMP 3.0.4 Nov 2, 2023
@vuule vuule added cuIO cuIO issue and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Nov 2, 2023
@vuule vuule marked this pull request as ready for review November 2, 2023 19:45
@vuule vuule requested a review from a team as a code owner November 2, 2023 19:45
@bdice
Copy link
Contributor

bdice commented Nov 2, 2023

/ok to test

@bdice bdice mentioned this pull request Nov 2, 2023
Closed
@bdice bdice added breaking Breaking change and removed non-breaking Non-breaking change labels Nov 2, 2023
@vuule vuule mentioned this pull request Nov 9, 2023
Merged
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Nov 9, 2023
@vuule
Update nvcomp to 3.0.4 (includes API changes) (#314)
b8f6218 
Update the nvCOMP version used for compression/decompression to 3.0.4.

See also:

rapidsai/cudf#13815
rapidsai/rapids-cmake#451

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Ray Douglass (https://github.com/raydouglass)

URL: #314
@bdice
Copy link
Contributor

bdice commented Nov 9, 2023

/ok to test

@bdice
Copy link
Contributor

bdice commented Nov 9, 2023

/merge

@bdice
Copy link
Contributor

bdice commented Nov 9, 2023

^ Triggering a merge for when CI finishes. I expect it to pass based on the build logs I was watching.

@rapids-bot rapids-bot bot merged commit 9be4de5 into rapidsai:branch-23.12 Nov 10, 2023
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@bdice bdice bdice approved these changes

Assignees

@vuule vuule

Labels
breaking Breaking change cuIO cuIO issue feature request New feature or request
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @bdice @raydouglass