-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nvcomp to 3.0.4. #313
Conversation
Actually am now wondering, should we consider moving to nvCOMP 3 breaking? |
We can mark it as breaking, to alert users in case it matters. |
We'll have to disable devcontainers CI for this PR to pass, because it has a circular dependency with cudf. Done in 8654a3c. |
@madsbk Can you take a peek at this PR? I think there might be some nvcomp APIs that need to be updated for version 3.0.4, but I'm not entirely sure how kvikio works here.
|
I am not able to create the conda environment with
Any thoughts? |
@madsbk This is failing for the same reason I had to disable devcontainers -- current builds of libcudf are pinned to |
I tried my hand at implementing the changes required due to the API change, but I can't get the functors in Cython quite right |
Closing this PR in favor of #314. |
Description
Update the nvCOMP version used for compression/decompression to 3.0.4.
See also: