Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move chars column to parent data buffer in strings column #14202

Merged
merged 73 commits into from
Jan 17, 2024
Merged

Move chars column to parent data buffer in strings column #14202

merged 73 commits into from
Jan 17, 2024

Commits on Sep 26, 2023

  1. add stream to chars(), chars_size, chars_end, use head()

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f5ca3d3 View commit details
    Browse the repository at this point in the history

  2. src/ changes

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    aced40d View commit details
    Browse the repository at this point in the history

  3. tests/ changes

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7c34040 View commit details
    Browse the repository at this point in the history

  4. benchmarks/ changes

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b592458 View commit details
    Browse the repository at this point in the history

  5. java/ changes

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    86a1e59 View commit details
    Browse the repository at this point in the history

  6. examples/ changes

    @karthikeyann
    karthikeyann committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    55dce95 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'branch-23.10' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    8212300 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @karthikeyann
    karthikeyann committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a874f32 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. python/ changes

    @karthikeyann
    karthikeyann committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3b23642 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Merge branch 'branch-23.12' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    766c939 View commit details
    Browse the repository at this point in the history

  2. string fixes for contiguous split (nvdbaranec)

    @karthikeyann
    karthikeyann committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    75d683c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. fix view char ptr, naming with numbers for a pytest

    @karthikeyann
    karthikeyann committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5e4ef98 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.12' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8ff34b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. base_data fix in strings column in Cython

    @karthikeyann
    karthikeyann committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a900572 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.12' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    88c2b36 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. fix serialization of sliced string column

    @karthikeyann
    karthikeyann committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ee1fff2 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix test_assert_column_memory_basic_same for string column

    @karthikeyann
    karthikeyann committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dc5acd9 View commit details
    Browse the repository at this point in the history

  2. fix test_deserialize_cudf_0_16, rename to 23_12

    @karthikeyann
    karthikeyann committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    902b466 View commit details
    Browse the repository at this point in the history

  3. fix ParquetWriterTest.StringsAsBinary test

    @karthikeyann
    karthikeyann committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    13aa651 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-23.12' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7f67403 View commit details
    Browse the repository at this point in the history

  5. fix tokenize_with_vocabulary for new string design

    @karthikeyann
    karthikeyann committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ddca840 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. fix strings column_view creation children

    @karthikeyann
    karthikeyann committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e2fd78c View commit details
    Browse the repository at this point in the history

  2. revert bpe change for resolving merge conflicts

    @karthikeyann
    karthikeyann committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    804797c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-23.12' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    bc977fb View commit details
    Browse the repository at this point in the history

  4. fix bpe after merge

    @karthikeyann
    karthikeyann committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    678d171 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. java-fixes.patch by @jlowe

    @karthikeyann
    karthikeyann committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    cdbc925 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge branch 'branch-24.02' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a99aef7 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. address review comments (use head() instead of data())

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    979f032 View commit details
    Browse the repository at this point in the history

  2. add rmm buffer for chars for string factory

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    47f421a View commit details
    Browse the repository at this point in the history

  3. remove chars() in strings_column_view

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    08084ef View commit details
    Browse the repository at this point in the history

  4. fix nullable column_view to device_span error

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    f171405 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4dfb1ab View commit details
    Browse the repository at this point in the history

  6. remove char hack for rep layout

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    71017bd View commit details
    Browse the repository at this point in the history

  7. deprecate chars()

    @karthikeyann
    karthikeyann committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    71451d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a7c14c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Apply suggestions from code review 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ff1decf View commit details
    Browse the repository at this point in the history

  2. style fix

    @karthikeyann
    karthikeyann committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    fa6ba9d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    85643e8 View commit details
    Browse the repository at this point in the history

  2. add proclaim_return_type to device lambda

    @karthikeyann
    karthikeyann committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    57f1d47 View commit details
    Browse the repository at this point in the history

  3. Update cpp/tests/strings/array_tests.cpp 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7b213f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. remove offset() and use offsets.size() 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    2773242 View commit details
    Browse the repository at this point in the history

  2. add stream to chars_begin()

    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    74b3567 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-24.02' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    53fbbff View commit details
    Browse the repository at this point in the history

  4. copyright year update

    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    1878691 View commit details
    Browse the repository at this point in the history

  5. merge fix

    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    d89caab View commit details
    Browse the repository at this point in the history

  6. Revert "copyright year update" 

    This reverts commit 1878691.
    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    a368c35 View commit details
    Browse the repository at this point in the history

  7. copyright year update

    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    54591c6 View commit details
    Browse the repository at this point in the history

  8. fix missing stream, fix typo

    @karthikeyann
    karthikeyann committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    15a43e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. fix format, address review comments

    @karthikeyann
    karthikeyann committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f4294de View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. fix stream

    @karthikeyann
    karthikeyann committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d9a2c5b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    dfc34a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. remove unused file copyright year

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a04413f View commit details
    Browse the repository at this point in the history

  2. string column children fix in column_empty

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    84de944 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8d4dc7d View commit details
    Browse the repository at this point in the history

  4. StringsColumnTest.GatherTooBig test column_view fix children

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    40553fe View commit details
    Browse the repository at this point in the history

  5. cleanup string.py

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b31d7f0 View commit details
    Browse the repository at this point in the history

  6. remove chars_data, use data itself with special case for string

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d311a68 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'branch-24.02' of github.com:rapidsai/cudf into fea-char… 

    …_limit_experiment
    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a37555d View commit details
    Browse the repository at this point in the history

  8. avoid deep copy for offset=0, in string column .data

    @karthikeyann
    karthikeyann committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d175bb9 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    95b2a3f View commit details
    Browse the repository at this point in the history

  2. address review comments 

    use Optional
move string special case for data to string.py
use data for memory usage calculation
remove chars_data declaration
    @karthikeyann
    karthikeyann committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d3db9e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f543551 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. zero size buffer for column_empty

    @karthikeyann
    karthikeyann committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f2e6e15 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e7ff5c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Update DEVELOPER_GUIDE.md

    @karthikeyann
    karthikeyann authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    906f27e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    39ee47d View commit details
    Browse the repository at this point in the history

  3. update strings.png

    @karthikeyann
    karthikeyann committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    555cc67 View commit details
    Browse the repository at this point in the history

  4. Update cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4f4ee07 View commit details
    Browse the repository at this point in the history

  5. remove space at end

    @karthikeyann
    karthikeyann authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    87b8bce View commit details
    Browse the repository at this point in the history

  6. remove int8 usage in string.py

    @karthikeyann
    karthikeyann committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    3ed1557 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    debf7de View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f8e5845 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Merge branch 'branch-24.02' into fea-char_limit_experiment

    @karthikeyann
    karthikeyann authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a577c88 View commit details
    Browse the repository at this point in the history