Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _from_data instead of _from_columns for initialzing Frame #14755

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

mroeschke
Copy link
Contributor

Description

In the spirit of reducing redundant methods, _from_columns just calls _from_data (hoping to rename to _from_mapping or similar) so removing the need for _from_columns.

Hoping to do the same for the _from_columns_like_self in a follow up.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 12, 2024 20:04
@isVoid
Copy link
Contributor

isVoid commented Jan 13, 2024

A bit of background for _from_columns - this was introduced when we want to refactor the cython layer with only list of columns input and output. _from_columns was just a sugar to make constructing from the result of a cython function easier.

@mroeschke
Copy link
Contributor Author

this was introduced when we want to refactor the cython layer with only list of columns input and output

Is this still an effort being worked on? My observation of the current usage is that it tends to always be paired with column labels like _from_data.

@isVoid
Copy link
Contributor

isVoid commented Jan 18, 2024

If I remember correctly, the remaining work to be done are cuio cython APIs. But this work shouldn't be block by that, in fact, follow ups to that refactor can always resort to _from_data.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 70cdeec into rapidsai:branch-24.02 Jan 18, 2024
67 checks passed
@mroeschke mroeschke deleted the ref/rm/from_columns branch January 18, 2024 17:22
@vyasr
Copy link
Contributor

vyasr commented Jan 18, 2024

this was introduced when we want to refactor the cython layer with only list of columns input and output

Is this still an effort being worked on? My observation of the current usage is that it tends to always be paired with column labels like _from_data.

This work was put on hold because I decided that getting pylibcudf done first would be better. Most of the structure that I imagined imposing at the Cython layer will be largely informed by refactoring cudf internals around pylibcudf objects once pylibcudf is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants