-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cudf::char_utf8 definition from detail to public header #14779
Move cudf::char_utf8 definition from detail to public header #14779
Conversation
@davidwendt Do we need to update cudf/docs/cudf/source/conf.py accordingly? |
That is a good question. I made @vyasr a reviewer. I think that I can just remove the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this David! Yes, you can remove the comment as well as the line below it that actually says "char_utf8"
.
/merge |
Description
Moves the
cudf::char_utf8
definition from thecudf/strings/detail/utf8.hpp
tocudf/types.hpp
since it is declared in the public namespace and used in public functions.Reference:
cudf/docs/cudf/source/conf.py
Lines 372 to 375 in 9acddc0
Checklist