Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cudf::char_utf8 definition from detail to public header #14779

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Move cudf::char_utf8 definition from detail to public header #14779

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d76f28d
Move char_utf8 definition from detail to public header
davidwendt Jan 18, 2024
b6e2d55
Merge branch 'branch-24.02' into move-char-utf8-to-public
davidwendt Jan 19, 2024
6a73ccc
remove char_utf8 from conf.py
davidwendt Jan 19, 2024
21e12fa
Merge branch 'branch-24.02' into move-char-utf8-to-public
vyasr Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cpp/include/cudf/strings/detail/utf8.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
* Copyright (c) 2022-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,9 +23,6 @@
*/

namespace cudf {

using char_utf8 = uint32_t; ///< UTF-8 characters are 1-4 bytes

namespace strings {
namespace detail {

Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ class mutable_column_view;
class string_view;
class list_view;
class struct_view;

class scalar;

// clang-format off
Expand Down Expand Up @@ -95,6 +94,7 @@ using size_type = int32_t; ///< Row index type for columns and tables
using bitmask_type = uint32_t; ///< Bitmask type stored as 32-bit unsigned integer
using valid_type = uint8_t; ///< Valid type in host memory
using thread_index_type = int64_t; ///< Thread index type in kernels
using char_utf8 = uint32_t; ///< UTF-8 characters are 1-4 bytes

/**
* @brief Similar to `std::distance` but returns `cudf::size_type` and performs `static_cast`
Expand Down
Loading