Remove host_parse_nested_json. #15674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
|
Although this is a deletion, I think this is "non-breaking" because the changes are all in the |
bdice
commented
May 6, 2024
| * @param options Parsing options specifying the parsing behaviour | ||
| * @param stream The CUDA stream to which kernels are dispatched | ||
| * @param mr Optional, resource with which to allocate | ||
| * @return The data parsed from the given JSON input | ||
| */ | ||
| table_with_metadata device_parse_nested_json(device_span<SymbolT const> input, |
There was a problem hiding this comment.
Should we rename device_parse_nested_json to parse_nested_json? We are removing the host implementation in this PR, which previously existed only for debugging.
There was a problem hiding this comment.
I'm ok with keeping the name.
davidwendt
approved these changes
May 6, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a task from #15537 to remove the
host_parse_nested_jsoncode path and corresponding tests. See discussion in #15568 (comment).Checklist