patch thrust to fix intmax num elements limitation in scan_by_key #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
harrism
approved these changes
May 10, 2021
…nto thrust-patch-intmax-scan
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8199 +/- ##
===============================================
- Coverage 82.88% 82.88% -0.01%
===============================================
Files 103 104 +1
Lines 17668 17907 +239
===============================================
+ Hits 14645 14843 +198
- Misses 3023 3064 +41
Continue to review full report at Codecov.
|
trxcllnt
approved these changes
May 11, 2021
|
@gpucibot merge |
This was referenced May 12, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
May 24, 2021
…_key" (#8263) Reverts #8199 According to @allisonvacanti (NVIDIA/thrust#1424 (comment)) this patch will likely have adverse effect on performance. We should revert it until a better solution can be found. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - David Wendt (https://github.com/davidwendt) - Keith Kraus (https://github.com/kkraus14) - Elias Stehle (https://github.com/elstehle) URL: #8263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same fix seen here, but via patch: NVIDIA/thrust#1424
Also fixes rapidsai/cuspatial#393
Alternatively, we could wait and update our thrust version, rather than patching the existing one.