Revert "patch thrust to fix intmax num elements limitation in scan_by_key" #8263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_key (rapidsai#8199)" This reverts commit ae08422.
…99-thrust-patch-intmax-scan
cwharris
added
bug
github-actions
bot
added
CMake
…199-thrust-patch-intmax-scan
raydouglass
changed the title
raydouglass
changed the title
|
Please add a complete description (like the PR this one replaces). |
cwharris
changed the title
…199-thrust-patch-intmax-scan
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8263 +/- ##
===============================================
Coverage ? 82.86%
===============================================
Files ? 105
Lines ? 17861
Branches ? 0
===============================================
Hits ? 14801
Misses ? 3060
Partials ? 0 Continue to review full report at Codecov.
|
cwharris
requested review from
kkraus14,
trxcllnt,
davidwendt,
elstehle and
harrism
|
Added original reviewers from #8226 |
davidwendt
approved these changes
May 24, 2021
kkraus14
approved these changes
May 24, 2021
elstehle
approved these changes
May 24, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8199
According to @allisonvacanti (NVIDIA/thrust#1424 (comment)) this patch will likely have adverse effect on performance. We should revert it until a better solution can be found.