Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add docstring for dask_cudf.read_csv #8355

Merged
merged 6 commits into from
May 26, 2021
Merged

[REVIEW] Add docstring for dask_cudf.read_csv #8355

merged 6 commits into from
May 26, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #2277

This PR adds python docstring for dask_cudf.read_csv API.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team doc Documentation 4 - Needs Dask Reviewer non-breaking Non-breaking change labels May 25, 2021
@galipremsagar galipremsagar self-assigned this May 25, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 25, 2021 19:35
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 25, 2021
kkraus14
kkraus14 reviewed May 25, 2021
View reviewed changes
python/dask_cudf/dask_cudf/io/csv.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/csv.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/csv.py Outdated Show resolved Hide resolved
galipremsagar and others added 3 commits May 25, 2021 15:55
@galipremsagar @kkraus14
Update python/dask_cudf/dask_cudf/io/csv.py
c0b3dfa 
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
@galipremsagar @kkraus14
Update python/dask_cudf/dask_cudf/io/csv.py
42a1368 
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
@galipremsagar @kkraus14
Update python/dask_cudf/dask_cudf/io/csv.py
0b9cd0c 
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels May 25, 2021
@galipremsagar @ayushdg
Apply suggestions from code review
76f5b7e 
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
@kkraus14
Copy link
Collaborator

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@6db757b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8355   +/-   ##
===============================================
  Coverage                ?   82.89%           
===============================================
  Files                   ?      105           
  Lines                   ?    17875           
  Branches                ?        0           
===============================================
  Hits                    ?    14817           
  Misses                  ?     3058           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db757b...e73b18f. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ddba88d into rapidsai:branch-21.06 May 26, 2021
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@ayushdg ayushdg ayushdg approved these changes

@rjzamora rjzamora Awaiting requested review from rjzamora

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dask_cudf.read_csv has no docstring
4 participants
@galipremsagar @kkraus14 @ayushdg @vyasr