Add shallow hash function and shallow equality comparison for column_view #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
…/cudf into fea-shallow_equal_columnview
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
…low_hash_columnview
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
…/cudf into fea-shallow_hash_columnview
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
karthikeyann
added
feature request
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9312 +/- ##
================================================
+ Coverage 10.79% 10.83% +0.04%
================================================
Files 116 116
Lines 18869 19255 +386
================================================
+ Hits 2036 2087 +51
- Misses 16833 17168 +335
Continue to review full report at Codecov.
|
|
I confirmed that the contents are identical to #9185 with @karthikeyann offline. Since that PR received four approvals before it was merged I'm comfortable going ahead and merging this PR with a single review. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9140
Added
shallow_hash(column_view)Added unit tests
SWIPAT approval complete
It computes hash values based on the shallow states of
column_view:type, size, data pointer, null_mask pointer, offset, and the hash value of the children.
null_countis not used since it is a cached value and it may vary based on contents ofnull_mask, and may be pre-computed or not.Fixes #9139
Added
is_shallow_equivalent(column_view, column_view)shallow_equalAdded unit tests
It compares two column_views based on the shallow states of column_view:
type, size, data pointer, null_mask pointer, offset, and the column_view of the children.
null_count is not used since it is a cached value and it may vary based on contents of null_mask, and may be pre-computed or not.