Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shallow hash function and shallow equality comparison for column_view #9312

Merged
merged 22 commits into from
Sep 27, 2021
Merged

Add shallow hash function and shallow equality comparison for column_view #9312

merged 22 commits into from
Sep 27, 2021

Commits on Sep 7, 2021

  1. add shallow_hash(column_view)

    @karthikeyann
    karthikeyann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    d421d6d View commit details
    Browse the repository at this point in the history

  2. add CompoundTypes to type_lists

    @karthikeyann
    karthikeyann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    9c4a9f3 View commit details
    Browse the repository at this point in the history

  3. add shallow_hash tests

    @karthikeyann
    karthikeyann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    a3dd235 View commit details
    Browse the repository at this point in the history

  4. add column copy test

    @karthikeyann
    karthikeyann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    2365d07 View commit details
    Browse the repository at this point in the history

  5. add shallow_equal(column_view) and tests

    @karthikeyann
    karthikeyann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    88726a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Update cpp/include/cudf/column/column_view.hpp 

    Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
    @karthikeyann @jrhemstad
    karthikeyann and jrhemstad authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    d9a8bd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. ignore data, nullmask, offset if parent size is empty

    @karthikeyann
    karthikeyann committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    7e7f250 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fea-shallow_hash_columnview' of github.com:karthikeyann… 

    …/cudf into fea-shallow_equal_columnview
    @karthikeyann
    karthikeyann committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    d1d5c3c View commit details
    Browse the repository at this point in the history

  3. is_shallow_equal ignore children states for empty column. (not childr… 

    …en type)
    @karthikeyann
    karthikeyann committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    0005154 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. for empty column, ignore child pointers in shallow_hash

    @karthikeyann
    karthikeyann committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    e692053 View commit details
    Browse the repository at this point in the history

  2. rename is_shallow_equal to is_shallow_equivalent

    @karthikeyann
    karthikeyann committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    44372bc View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. use hash_combine for shallow hash

    @karthikeyann
    karthikeyann committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    ecc3a7d View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review (jake) 

    Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
    @karthikeyann @jrhemstad
    karthikeyann and jrhemstad authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d2cd468 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. address review comments

    @karthikeyann
    karthikeyann committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    fa40847 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Merge branch 'branch-21.10' of github.com:rapidsai/cudf into fea-shal… 

    …low_hash_columnview
    @karthikeyann
    karthikeyann committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    f66fdd9 View commit details
    Browse the repository at this point in the history

  2. add boost license for hash_combine, move to diff header

    @karthikeyann
    karthikeyann committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    e36b834 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review (jake) 

    Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
    @karthikeyann @jrhemstad
    karthikeyann and jrhemstad authored Sep 18, 2021
    Configuration menu
    Copy the full SHA
    1fbe3fc View commit details
    Browse the repository at this point in the history

  4. include cleanup

    @karthikeyann
    karthikeyann committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    fc3cc6b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fea-shallow_hash_columnview' of github.com:karthikeyann… 

    …/cudf into fea-shallow_hash_columnview
    @karthikeyann
    karthikeyann committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    eb2b0db View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. address review comments

    @karthikeyann
    karthikeyann committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9581525 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Update cpp/src/column/column_view.cpp 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @karthikeyann @davidwendt
    karthikeyann and davidwendt authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1a5f367 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Merge branch 'rapidsai:branch-21.12' into fea-shallow_hash_columnview

    @karthikeyann
    karthikeyann authored Sep 27, 2021
    Configuration menu
    Copy the full SHA
    e9db170 View commit details
    Browse the repository at this point in the history