Fix memcheck error in copy-if-else #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
nvdbaranec
approved these changes
Oct 19, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9467 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19755 +886
================================================
+ Hits 2036 2106 +70
- Misses 16833 17649 +816
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Oct 19, 2021
vuule
reviewed
Oct 19, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA memcheck write error was introduced in #9324 (by me). The
has_nullshandling had been reworked but a logic error allowed writing past the end of the output column.This PR also includes fixes to remove compile warnings in
group_correlation.cuthat only start to appear in nvcc 11.4.