Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memcheck error in copy-if-else #9467

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Fix memcheck error in copy-if-else #9467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaf4d5a
Fix memcheck write error in copy-if-else
davidwendt Oct 19, 2021
7a35e98
fix unused var compiling warning
davidwendt Oct 19, 2021
b0bb4bc
Merge branch 'branch-21.12' of github.com:rapidsai/cudf into branch-2…
davidwendt Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/cudf/detail/copy_if_else.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ __launch_bounds__(block_size) __global__
while (warp_cur <= warp_end) {
auto const opt_value =
(index < end) ? (filter(index) ? lhs[index] : rhs[index]) : thrust::nullopt;
if (not has_nulls or opt_value) { out.element<T>(index) = static_cast<T>(*opt_value); }
if (opt_value) { out.element<T>(index) = static_cast<T>(*opt_value); }

// update validity
if (has_nulls) {
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/groupby/sort/group_correlation.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ struct type_casted_accessor {
if constexpr (column_device_view::has_element_accessor<Element>() and
std::is_convertible_v<Element, CastType>)
return static_cast<CastType>(col.element<Element>(i));
(void)i;
vuule marked this conversation as resolved.
Show resolved Hide resolved
(void)col;
return {};
}
};
Expand Down