Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add librdkafka and python-confluent-kafka to dev conda environments s… #9562

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Oct 29, 2021

Custreamz dependencies have been missing from the conda development environments files causing confusion and slowing down dev cycles.

@jdye64 jdye64 requested a review from a team as a code owner October 29, 2021 17:16
@github-actions github-actions bot added the conda label Oct 29, 2021
@vyasr vyasr added 3 - Ready for Review Ready for review by team cuStreamz improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #9562 (86aa232) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9562      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19726     +857     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17622     +789     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12b691...86aa232. Read the comment docs.

@jdye64
Copy link
Contributor Author

jdye64 commented Nov 2, 2021

@ajschmidt8 could someone merge this since it seems the only tests that are failing are the 11.5 ones and we are ignoring those for now right?

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d674c55 into rapidsai:branch-21.12 Nov 2, 2021
@jakirkham
Copy link
Member

Thanks Jeremy for the PR and AJ for the review! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants