Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 support, prefer absolute paths in Dockerfiles #102

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#40

RAPIDS is adding support for Python 3.12 in its 24.10 release. All of the libraries used by images built from this repo (cudf, dask-cudf, ucx-py) have been updated... so this proposes adding Python 3.12 images here.

Notes for Reviewers

How I tested this

On an x86_64 machine with CUDA driver 535:

cd ./dask

docker build \
    -t delete-me:dask \
    --build-arg RAPIDS_VER="24.10" \
    --build-arg UCX_PY_VER="0.40" \
    --build-arg CUDA_VER="11.8.0" \
    --build-arg LINUX_VER="ubuntu20.04" \
    --build-arg PYTHON_VER="3.12" \
    -f ./Dockerfile \
    .

docker run \
  --rm \
  --gpus 1 \
  -it delete-me:dask \
   bash -c "source activate dask; python -c 'import cudf; print(cudf.__version__)'"
# 24.10.00a310

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 10, 2024
@jameslamb jameslamb requested a review from a team as a code owner September 10, 2024 22:38
@jameslamb jameslamb changed the title add Python 3.12 support add Python 3.12 support, prefer absolute paths in Dockerfiles Sep 10, 2024
@@ -31,7 +31,7 @@ RUN cat /dask.yml \
| sed -r "s/pyarrow=/pyarrow>=/g" \
| sed -r "s/pandas=/pandas>=/g" \
| sed -r "s/numpy=/numpy>=/g" \
> dask_unpinned.yml
> /dask_unpinned.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right below, this is referenced as /dask_unpinned.yml (absolute path).

That means this has only been working because the working directory happens to be /. Making this an absolute path just makes this a little safer, in case that working directory is changed in the base image in the future.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jameslamb .

@charlesbluca charlesbluca merged commit 5d9d592 into rapidsai:main Sep 11, 2024
@charlesbluca
Copy link
Member

charlesbluca commented Sep 11, 2024

Thanks @jameslamb! Just kicked off a rebuild of the image matrix (you should be able to see the status of all runs here)

@jameslamb
Copy link
Member Author

Thanks! Looks like that was successful.

It's suuuuper nice that you get a visual summary like this!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants