Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Python 3.12 support, prefer absolute paths in Dockerfiles #102

Merged
merged 3 commits into from
Sep 11, 2024
Merged

add Python 3.12 support, prefer absolute paths in Dockerfiles #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0729c18
add Python 3.12 support
jameslamb Sep 10, 2024
d200e38
exclude Python 3.12 RAPIDS 24.08 builds
jameslamb Sep 10, 2024
a33e5e4
absolute paths
jameslamb Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/axis/dask.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ CUDA_VER:
PYTHON_VER:
- '3.10'
- '3.11'
- '3.12'

LINUX_VER:
- ubuntu20.04
Expand All @@ -21,3 +22,6 @@ excludes:
# dask-image gpuCI isn't dependent on RAPIDS
- BUILD_NAME: dask_image
RAPIDS_VER: '24.08'
# Python 3.12 support was first added in RAPIDS 24.10
- PYTHON_VER: '3.12'
RAPIDS_VER: '24.08'
2 changes: 1 addition & 1 deletion dask/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RUN cat /dask.yml \
| sed -r "s/pyarrow=/pyarrow>=/g" \
| sed -r "s/pandas=/pandas>=/g" \
| sed -r "s/numpy=/numpy>=/g" \
> dask_unpinned.yml
> /dask_unpinned.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right below, this is referenced as /dask_unpinned.yml (absolute path).

That means this has only been working because the working directory happens to be /. Making this an absolute path just makes this a little safer, in case that working directory is changed in the base image in the future.


RUN conda-merge /rapids_pinned.yml /dask_unpinned.yml > /dask.yml

Expand Down
2 changes: 1 addition & 1 deletion distributed/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RUN cat /rapids.yml \
# unpin problematic CI dependencies
RUN cat /dask.yml \
| sed -r "s/pyarrow=/pyarrow>=/g" \
> dask_unpinned.yml
> /dask_unpinned.yml

RUN conda-merge /rapids_pinned.yml /dask_unpinned.yml > /distributed.yml

Expand Down