rauc-installer: refactoring and bug fixes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoerns
requested changes
Dec 17, 2020
| g_autoptr(GError) error = NULL; | ||
| struct install_context *context = NULL; | ||
|
|
||
| g_return_val_if_fail(data, NULL); |
There was a problem hiding this comment.
nit: in the other commits you simply did g_return_val_if_fail(context) which is inconsistent with this one.
Clean and improve this function: - update rauc installer doc reference - sanity check input arguments - fix leaking message with g_autofree (g_variant_lookup() copies the string, see [1]) - make error output warning log output - wrap long lines - separate nested function calls - perform empty queue check under lock - remove unused depth variable, pass NULL instead [1] https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-strings Signed-off-by: Bastian Krause <bst@pengutronix.de>
Clean and improve this function: - update rauc installer doc reference - sanity check input argument - simplify if condition Signed-off-by: Bastian Krause <bst@pengutronix.de>
Clean and improve this function: - simplify if condition Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/refactor-rauc-installer
branch
from
4e47d2b
to
957223d
Compare
|
Force-pushed:
|
Clean and improve this function: - use g_autoptr for error - sanity check input argument - wrap long lines - turn g_printerr() into g_warning() to make use of logging - clear RInstaller pointer - do not call g_signal_handlers_disconnect_by_data() with NULL pointer instance if proxy creation failed (goto later notify_complete label instead) Signed-off-by: Bastian Krause <bst@pengutronix.de>
Clean and improve this function: - remove duplicate doc string - wrap long lines - sanity check input arguments Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/refactor-rauc-installer
branch
from
957223d
to
82ede15
Compare
|
Added to commit "rauc-installer: refactor install_loop_thread()":
|
ejoerns
approved these changes
Dec 23, 2020
Bastian-Krause
added a commit
to Bastian-Krause/rauc-hawkbit-updater
that referenced
this pull request
Mar 30, 2021
Bastian-Krause
added a commit
to Bastian-Krause/rauc-hawkbit-updater
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fourth of a series of PRs to refactor and clean up the code base, get rid of bugs (memory leaks, use-after-frees, race conditions), simplify functions and document them.
In this iteration I focused on the
rauc-installermodule.