Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rauc-installer: refactoring and bug fixes #66

Merged
merged 5 commits into from
Jan 5, 2021

Commits on Dec 21, 2020

  1. rauc-installer: refactor on_installer_status()

    Clean and improve this function:
    - update rauc installer doc reference
    - sanity check input arguments
    - fix leaking message with g_autofree (g_variant_lookup() copies the
      string, see [1])
    - make error output warning log output
    - wrap long lines
    - separate nested function calls
    - perform empty queue check under lock
    - remove unused depth variable, pass NULL instead
    
    [1] https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-strings
    
    Signed-off-by: Bastian Krause <bst@pengutronix.de>
    Bastian-Krause committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    25fdfdd View commit details
    Browse the repository at this point in the history
  2. rauc-installer: refactor on_installer_completed()

    Clean and improve this function:
    - update rauc installer doc reference
    - sanity check input argument
    - simplify if condition
    
    Signed-off-by: Bastian Krause <bst@pengutronix.de>
    Bastian-Krause committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    462981a View commit details
    Browse the repository at this point in the history
  3. rauc-installer: refactor install_context_free()

    Clean and improve this function:
    - simplify if condition
    
    Signed-off-by: Bastian Krause <bst@pengutronix.de>
    Bastian-Krause committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    37b1885 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. rauc-installer: refactor install_loop_thread()

    Clean and improve this function:
    - use g_autoptr for error
    - sanity check input argument
    - wrap long lines
    - turn g_printerr() into g_warning() to make use of logging
    - clear RInstaller pointer
    - do not call g_signal_handlers_disconnect_by_data() with NULL pointer
      instance if proxy creation failed (goto later notify_complete label
      instead)
    
    Signed-off-by: Bastian Krause <bst@pengutronix.de>
    Bastian-Krause committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    7f78bab View commit details
    Browse the repository at this point in the history
  2. rauc-installer: refactor rauc_install()

    Clean and improve this function:
    - remove duplicate doc string
    - wrap long lines
    - sanity check input arguments
    
    Signed-off-by: Bastian Krause <bst@pengutronix.de>
    Bastian-Krause committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    82ede15 View commit details
    Browse the repository at this point in the history