feat(Apple Pay): validate and support more ApplePayPaymentRequest features #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarton
force-pushed
the
apple-pay-passthrough
branch
from
b7593f7
to
5df5884
Compare
cbarton
force-pushed
the
apple-pay-passthrough
branch
from
5df5884
to
1052578
Compare
…tures When Recurly supports more of the supported networks, ensure that the client will only query those that are supported by their browser to avoid any potential errors. This also adds support to pass in an `ApplePayLineItem` into the `options.total` since the current options limit just the properties of the total line item to just the `label` and `total`. Note that using this interface will ignore `options.label`. `options.label` is deprecated and optional in favor of the above. If not supplied with a dollar amount in `options.total`, the new `options.i18n.totalLineItemLabel` will be used, which is defaulted to "Total". Added support for passing in an array of `ApplePayLineItem`'s via `option.lineItems`. This and the `total` are still overridden by the presence `options.pricing`. Removes the payment request properties from the `ApplePay#config` property in favor of storing the full request in the psuedo-private `_applePayPaymentRequest` property. Adds the boolean option `enforceVersion`, which will raise an `apple-pay-not-supported` error if the client does not support the minimum version for certain features, like `requiredShippingContactFields`.
cbarton
force-pushed
the
apple-pay-passthrough
branch
from
1052578
to
bc97b2b
Compare
cbarton
force-pushed
the
apple-pay-passthrough
branch
from
bc97b2b
to
266d931
Compare
|
PR build shows as canceled, but all jobs therein passed |
chrissrogers
approved these changes
Mar 29, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Apr 19, 2023
[Full Changelog](v4.22.9...v4.23.0) **Merged Pull Requests** - chore(paypal): add types for display options [#812](#812) ([cbarton](https://github.com/cbarton)) - fix(apple pay): Do not teardown Braintree on cancel [#811](#811) ([cbarton](https://github.com/cbarton)) - fix(types): add type definition for Recurly#ready [#810](#810) ([cbarton](https://github.com/cbarton)) - feat(google pay): add support for the paymentDataRequest [#809](#809) ([cbarton](https://github.com/cbarton)) - feat(Apple Pay): allow for customization of event updates [#808](#808) ([cbarton](https://github.com/cbarton)) - Update config type with requiredShippingContactFields [#806](#806) ([BARK-RMILLER](https://github.com/BARK-RMILLER)) - feat(apple pay): add support for `recurringPaymentRequest`, move to `options.paymentRequest` [#804](#804) ([cbarton](https://github.com/cbarton)) - fix(apple pay): emit events when restore pricing addresses [#803](#803) ([cbarton](https://github.com/cbarton)) - chore(apple pay): capture async test errors to fail faster [#802](#802) ([cbarton](https://github.com/cbarton)) - feat(apple pay): populate contacts with pricing addresses [#801](#801) ([cbarton](https://github.com/cbarton)) - feat(apple pay): allow for supportedNetworks selection [#800](#800) ([cbarton](https://github.com/cbarton)) - feat(apple pay): update tax when billing/shipping contact changes [#798](#798) ([cbarton](https://github.com/cbarton)) - feat(apple pay): populate billingContact with form address fields [#797](#797) ([cbarton](https://github.com/cbarton)) - feat(Apple Pay): validate and support more ApplePayPaymentRequest features [#794](#794) ([cbarton](https://github.com/cbarton)) - [feat][google-pay] send raw payment data to server [#789](#789) ([cbarton](https://github.com/cbarton)) **Closed Issues** - property 'ready' does not exist on type 'Recurly'.ts [#795](#795) - Missing types definitions for `coupon` method [#698](#698) - If formRef unmounts during call, recurly.token fails silently. [#697](#697) - The user can enter 4 digits as the month value in the expiration date field. [#678](#678) ##### Minified MD5 Checksum ``` 75584733b78f6ca6c6a65267b07fb9ad ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` pX41INy9qepZfHHYL13noWEbReg+bDOqU2jzjgkC3kkDh36KlPFeiJBxUgca8DtP ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Recurly supports more of the supported networks, ensure that the client will only query those that are supported by their browser to avoid any potential errors.
This also adds support to pass in an
ApplePayLineIteminto theoptions.totalsince the current options limit just the properties of the total line item to just thelabelandtotal. Note that using this interface will ignoreoptions.label.options.labelis deprecated and optional in favor of the above. If not supplied with a dollar amount inoptions.total, the newoptions.i18n.totalLineItemLabelwill be used, which is defaulted to "Total".Added support for passing in an array of
ApplePayLineItem's viaoption.lineItems. This and thetotalare still overridden by the presenceoptions.pricing.Removes the payment request properties from the
ApplePay#configproperty in favor of storing the full request in the psuedo-private_applePayPaymentRequestproperty.Adds the boolean option
enforceVersion, which will raise anapple-pay-not-supportederror if the client does not support the minimum version for certain features, likerequiredShippingContactFields.Adds the ability to pass through all
ApplePayPaymentRequestparameters to the session.