Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple pay): populate contacts with pricing addresses #801

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

cbarton
Copy link
Member

@cbarton cbarton commented Mar 30, 2023

Pricing is the recommended way of integrating with Recurly.js, so use the address and shippingAddress properties of the price to populate the billingContact and shippingContact over the form address. The address.phone is part of the shippingContact in Apple terms so it shows in the payment sheet.

@coveralls
Copy link

coveralls commented Mar 31, 2023

Coverage Status

Coverage: 92.439% (+0.002%) from 92.436% when pulling 65a430b on pricing-contacts into 29f08bd on master.

Pricing is the recommended way of integrating with Recurly.js, so use
the `address` and `shippingAddress` properties of the `price` to
populate the `billingContact` and `shippingContact` over the `form`
address. The `address.phone` is part of the `shippingContact` in Apple
terms so it shows in the payment sheet.
@chrissrogers chrissrogers merged commit 98da3fb into master Mar 31, 2023
@chrissrogers chrissrogers deleted the pricing-contacts branch March 31, 2023 21:27
recurly-integrations pushed a commit that referenced this pull request Apr 19, 2023
[Full Changelog](v4.22.9...v4.23.0)

**Merged Pull Requests**

- chore(paypal): add types for display options [#812](#812) ([cbarton](https://github.com/cbarton))
- fix(apple pay): Do not teardown Braintree on cancel [#811](#811) ([cbarton](https://github.com/cbarton))
- fix(types): add type definition for Recurly#ready [#810](#810) ([cbarton](https://github.com/cbarton))
- feat(google pay): add support for the paymentDataRequest [#809](#809) ([cbarton](https://github.com/cbarton))
- feat(Apple Pay): allow for customization of event updates [#808](#808) ([cbarton](https://github.com/cbarton))
- Update config type with requiredShippingContactFields [#806](#806) ([BARK-RMILLER](https://github.com/BARK-RMILLER))
- feat(apple pay): add support for `recurringPaymentRequest`, move to `options.paymentRequest` [#804](#804) ([cbarton](https://github.com/cbarton))
- fix(apple pay): emit events when restore pricing addresses [#803](#803) ([cbarton](https://github.com/cbarton))
- chore(apple pay): capture async test errors to fail faster [#802](#802) ([cbarton](https://github.com/cbarton))
- feat(apple pay): populate contacts with pricing addresses [#801](#801) ([cbarton](https://github.com/cbarton))
- feat(apple pay): allow for supportedNetworks selection [#800](#800) ([cbarton](https://github.com/cbarton))
- feat(apple pay): update tax when billing/shipping contact changes [#798](#798) ([cbarton](https://github.com/cbarton))
- feat(apple pay): populate billingContact with form address fields [#797](#797) ([cbarton](https://github.com/cbarton))
- feat(Apple Pay): validate and support more ApplePayPaymentRequest features [#794](#794) ([cbarton](https://github.com/cbarton))
- [feat][google-pay] send raw payment data to server [#789](#789) ([cbarton](https://github.com/cbarton))

**Closed Issues**

- property 'ready' does not exist on type 'Recurly'.ts [#795](#795)
- Missing types definitions for `coupon` method [#698](#698)
- If formRef unmounts during call, recurly.token fails silently. [#697](#697)
- The user can enter 4 digits as the month value in the expiration date field. [#678](#678)

##### Minified MD5 Checksum
```
75584733b78f6ca6c6a65267b07fb9ad ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
pX41INy9qepZfHHYL13noWEbReg+bDOqU2jzjgkC3kkDh36KlPFeiJBxUgca8DtP
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants