Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the readme to show "Modern Redux" patterns and practices #515

Closed
markerikson opened this issue Oct 20, 2021 · 1 comment
Closed
Labels

Comments

@markerikson
Copy link
Contributor

Per #355 , the README now at least uses selectX as the naming convention, but all the examples are still based on connect and "hand-written legacy Redux" patterns.

We need to rewrite those to show use of function components, Redux Toolkit, and useSelector instead, as well as the advice in the new Deriving Data with Selectors docs page.

@markerikson
Copy link
Contributor Author

Partly done-ish, but could use some more updates.

aryaemami59 added a commit to aryaemami59/reselect that referenced this issue Nov 11, 2023
- Add documentation regarding new features.
- Redo `CodeSandbox` examples to align better with documentation. Solves reduxjs#598.
- Fix GitHub workflow badge URL reduxjs#628.
- Add instructions for `bun` and `pnpm`. Solves reduxjs#621.
- Fix minor type issues regarding `createStructuredSelector`. Solves reduxjs#499.
- `argsMemoize` and `argsMemoizeOptions` solve reduxjs#359.
- Remove `Redux` legacy patterns including `connect` and `switch` statements from docs.  Solves reduxjs#515.
- Replace legacy code patterns with modern syntax like `useSelector` and functional components.
- Implementation of `argsMemoize` solves reduxjs#376.
- Document order of execution in `Reselect`. Solves reduxjs#455.
- Add benchmarks to confirm the info inside the documentation.
- Add more type tests with `vitest`.
- Fix more hover preview issues with types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant