feat: createStructuredSelector returns OutputSelector #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stropho
force-pushed
the
outputselector-type
branch
from
cae3a0a
to
adabb10
Compare
|
Still useful, but the PR is stale vs |
- original changes for version 4.0.0
- update types for v4.1
stropho
force-pushed
the
outputselector-type
branch
from
adabb10
to
7a5d024
Compare
|
Thx for the note. I wouldn't notice the change on master after quite a long time :) |
aryaemami59
added a commit
to aryaemami59/reselect
that referenced
this pull request
Nov 11, 2023
- Add documentation regarding new features. - Redo `CodeSandbox` examples to align better with documentation. Solves reduxjs#598. - Fix GitHub workflow badge URL reduxjs#628. - Add instructions for `bun` and `pnpm`. Solves reduxjs#621. - Fix minor type issues regarding `createStructuredSelector`. Solves reduxjs#499. - `argsMemoize` and `argsMemoizeOptions` solve reduxjs#359. - Remove `Redux` legacy patterns including `connect` and `switch` statements from docs. Solves reduxjs#515. - Replace legacy code patterns with modern syntax like `useSelector` and functional components. - Implementation of `argsMemoize` solves reduxjs#376. - Document order of execution in `Reselect`. Solves reduxjs#455. - Add benchmarks to confirm the info inside the documentation. - Add more type tests with `vitest`. - Fix more hover preview issues with types.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
unlike
createSelectorthat returnsOutputSelector, thecreateStructuredSelectorcurrently returns aSelector.What is the difference?
OutputSelectoris extendedSelectorand additionally, it includes:Those are great for testing purposes. These attributes are obviously there, but it is a bit awkward to access them in TS project.
The
resultFuncaccepts the the input selectors in somewhat unknown order, becauseObject.keysdoes not guarantee to return the same values in the same order in all environments. Thus the arguments ofresultFuncin this PR are justany. Nonetheless e.g.recomputationsare easily accessible.