Add types

[pd4d10]

No description provided.

[pd4d10]

https://travis-ci.org/github/remarkjs/remark-external-links/jobs/718949083#L235

  types/index.d.ts:3:22
  ✖  3:22  unified should be listed in the project's dependencies. Run npm i -S unified to add it  import/no-extraneous-dependencies

Shall we add it to dependencies or disable this rule?

[ChristianMurphy]

Shall we add it to dependencies or disable this rule?

I'll defer to @wooorm on this one, IIRC the current preference is to disable this rule.

[pd4d10]

Another question, should RemarkExternalLinksOptions be exposed to users?

[ChristianMurphy]

Another question, should RemarkExternalLinksOptions be exposed to users?

Yes, unified/remark plugins often depend on each other, having options exported/on the namespace allows reuse.

[wooorm]

lgtm, with RemarkExternalLinksOptions!

[pd4d10]

Another question, should RemarkExternalLinksOptions be exposed to users?

Currently we use export = remarkExternalLinks and could not do something like export { RemarkExternalLinksOptions } any more. Is there any best practice for this case?

[ChristianMurphy]

There is,
export = is needed to ensure that the types work when https://www.typescriptlang.org/tsconfig#allowSyntheticDefaultImports is false.
to allow an interface to also be included use a namespace that matches the export.

For example https://github.com/remarkjs/remark-frontmatter/blob/main/types/index.d.ts#L5 and https://github.com/remarkjs/remark-frontmatter/blob/3414a84ef27ead52701cae985994f67f17b414da/types/index.d.ts#L61-L63

[pd4d10]

@ChristianMurphy Get it. Updated

[ChristianMurphy]

thanks @pd4d10! 🙇

[wooorm]

Thanks @pd4d10, released in 7.0.0!