-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types #1
Add types #1
Conversation
Thanks @mikaelkaron! |
Stole some tests from |
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @mikaelkaron!
Let's get a test case in for rename.convert
as well, and this will LGTM
Released, thanks @mikaelkaron! P.S. @ChristianMurphy I’ve been tagging things that add types as minor recently in the case of a package that’s likely not deep down in ancient versions of Node, and it’s going pretty well (as in, I haven‘t seen any issues) |
This PR is an attempt to add TypeScript types for this package. I saw in a related ticket that it's preferred to add types directly to the package in question rather than
@types
so that's what I did.JSDoc was taken from the
README.md