fix(remix-dev): Update create-remix to use the new examples repository

[machour]

Also removed some now obsolete eslint rules

[changeset-bot]

🦋 Changeset detected

Latest commit: e241c5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[machour]

I'm hitting a snag here: My changes to create-remix works in reality, but as far as I understand the testing process, the mock is trying to read from the removed folder.

Any guidance would be appreciated :)

[chaance]

Thanks @machour, I'll take a look at this tomorrow and see if I can help with the tests.

[chaance]

Pressed approve too early—looks like we've got some failing test cases here. Let's get those patched up and I'll merge this for the next release.

Also: could we add a changeset noting the bug fix since this is broken at the moment?

[machour]

@chaance You were supposed to help for the tests 😅 (see your previous reply)

As commented, the problem is that tests were mocking the request to https://github.com/remix-run/remix/tree/main/examples by using the examples folder from the currently checked out repo in the workflow.

Now that we moved examples to their own repository, this mock isn't usable anymore.

I suppose I'll have to create a basic-example.tar.gz fixture and configure msw to correctly respond with that mock, but I've been trying and failing to make things work.

Can someone guide me, or take over this last step from me? (I'll understand what I was missing from the diff)

[chaance]

@machour looking at it this morning!

[mcansh]

taking a look into this now :)

[machour]

Thank you @mcansh !

[chaance]

LGTM! @machour can we get conflicts resolved so I can merge this week? never mind on that, looks clean!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-fb631c9-20220927 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!