Maven wrapper 3.3.1 not upgrading to 3.3.2, but 3.2.0 *does*

[JackPGreen]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Summary:

Renovate has upgraded Maven Wrapper from 3.2.0 -> 3.3.1, but seems oblivious to 3.3.2 which has been out a while.

But when 3.2.0 is present, it does identify 3.3.2 as an upgrade.

I'm using the GitHub-hosted Renovate with a private repository, but for reproducibility have replicated in a dummy project using renovate CLI.

Reproducer

I've created reproducer from the template, but a worked example may also be helpful.

Maven wrapper 3.2.0

Make a dummy project, including Maven wrapper:

mvn archetype:generate -Dgoals=wrapper:3.2.0:wrapper -DgroupId=com.mycompany.app -DartifactId=my-app -DarchetypeArtifactId=maven-archetype-quickstart -DinteractiveMode=false

Run Renovate locally:

LOG_LEVEL=debug npx renovate --platform=local --onboarding=false

Identifies `3.3.2` is available

"maven-wrapper": [
           {
             "deps": [
               {
                 "depName": "maven",
                 "packageName": "org.apache.maven:apache-maven",
                 "currentValue": "3.9.9",
                 "replaceString": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip",
                 "datasource": "maven",
                 "versioning": "maven",
                 "updates": [],
                 "warnings": [],
                 "registryUrl": "https://repo.maven.apache.org/maven2",
                 "homepage": "https://maven.apache.org/",
                 "currentVersion": "3.9.9",
                 "currentVersionTimestamp": "2024-08-14T08:51:44.000Z",
                 "fixedVersion": "3.9.9"
               },
               {
                 "depName": "maven-wrapper",
                 "packageName": "org.apache.maven.wrapper:maven-wrapper",
                 "currentValue": "3.2.0",
                 "replaceString": "https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar",
                 "datasource": "maven",
                 "versioning": "maven",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "3.3.2",
                     "newValue": "3.3.2",
                     "releaseTimestamp": "2024-05-21T15:12:44.000Z",
                     "newMajor": 3,
                     "newMinor": 3,
                     "newPatch": 2,
                     "updateType": "minor",
                     "branchName": "renovate/maven-wrapper-3.x"
                   }
                 ],
                 "warnings": [],
                 "registryUrl": "https://repo.maven.apache.org/maven2",
                 "homepage": "https://maven.apache.org/",
                 "currentVersion": "3.2.0",
                 "currentVersionTimestamp": "2023-03-08T23:07:09.000Z",
                 "isSingleVersion": true,
                 "fixedVersion": "3.2.0"
               }
             ],
             "packageFile": ".mvn/wrapper/maven-wrapper.properties"
           }
         ]

Maven wrapper 3.3.1

Make a dummy project, including Maven wrapper:

mvn archetype:generate -Dgoals=wrapper:3.3.1:wrapper -DgroupId=com.mycompany.app -DartifactId=my-app -DarchetypeArtifactId=maven-archetype-quickstart -DinteractiveMode=false

Run Renovate locally:

LOG_LEVEL=debug npx renovate --platform=local --onboarding=false

Identifies no `maven-wrapper` updates

"maven-wrapper": [
           {
             "deps": [
               {
                 "depName": "maven",
                 "packageName": "org.apache.maven:apache-maven",
                 "currentValue": "3.9.9",
                 "replaceString": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip",
                 "datasource": "maven",
                 "versioning": "maven",
                 "updates": [],
                 "warnings": [],
                 "registryUrl": "https://repo.maven.apache.org/maven2",
                 "homepage": "https://maven.apache.org/",
                 "currentVersion": "3.9.9",
                 "currentVersionTimestamp": "2024-08-14T08:51:44.000Z",
                 "fixedVersion": "3.9.9"
               }
             ],
             "packageFile": ".mvn/wrapper/maven-wrapper.properties"
           }
         ]

Logs (if relevant)

No response

[RahulGautamSingh]

Can you reproduce in a public repo on Github? We need to see the config you are using as well.

[JackPGreen]

See onboarding PRs:

• Configure Renovate JackPGreen/renovate-maven-wrapper-3.2.0#1
  • Update dependency maven-wrapper to v3.3.2
• Configure Renovate JackPGreen/renovate-maven-wrapper-3.3.1#1
  • No maven-wrapper dependency references

[JackPGreen]

I've created a reproducer from the template.

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[JackPGreen]

I've created a reproducer from the template.

[rarkins]

The reproduction does not reproduce. It generates an update to 3.3.2 as expected: renovate-reproductions/31696#3

[JackPGreen]

That's 3.2.0 - which does upgrade to 3.3.2.

It's 3.3.1 (or 3.3.0) that doesn't upgrade to 3.3.2.

See my reproducer here.

[JackPGreen]

I've created a reproducer from the template.

[JackPGreen]

Looking further, I wonder if the problem is with the Maven wrapper 3.3.x config.

Compare the config from 3.2.0:
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

To 3.3.1:
wrapperVersion=3.3.1

I can only see Renovate support for wrapperUrl, not wrapperVersion.

[JackPGreen]

Related discussion - #28648

(I didn't find this when I originally searched, apologies)

[JackPGreen]

Raised a PR - #31809