feat(maven-wrapper): wrapperVersion support
#31809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulGautamSingh
approved these changes
Oct 6, 2024
rarkins
previously approved these changes
Oct 7, 2024
auto-merge was automatically disabled
October 7, 2024 08:46
Head branch was pushed to by a user without write access
rarkins
approved these changes
Oct 11, 2024
|
🎉 This PR is included in version 38.118.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add ability to extract Maven Wrapper version from new
wrapperVersionproperty, in addition to existingwrapperUrlproperty.Specifically:
urltoreplaceStringto match how it's used elsewherewrapperVersion, used when parsing for a versionContext
Renovate currently detects the Maven Wrapper version using the
wrapperUrlproperty.This property was removed in apache/maven-wrapper#114 (
3.3.0), and replaced with a newwrapperVersionproperty in apache/maven-wrapper#135 (3.3.1).Renovate does not support
wrapperVersionproperty and is unable to identify / upgrade these newer versions.This directly addresses #31696.
A related discussion is at #28648 - but note that Maven Wrapper
3.3.0specifically has neither awrapperUrl, nor awrapperVersionand is not handled by this pull request, and further development is required. Earlier / later versions are supported.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: