Revert recent change to avoid using Arc:ptr_eq #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a clippy warning about Arc::ptr_eq potentially comparing vtable meta data associated with wide pointers there was a recent change to explicitly only check the address pointers and discard any wide pointer meta data. The Rust libs team has since resolved to update Arc::ptr_eq so that it doesn't compare meta data for the wrapped value (such as a dyn trait vtable): rust-lang/rust#103763 In the meantime we can silence this clippy suggestion since the vtable is benign in this case anyway: rust-lang/rust-clippy#6524
MarijnS95
reviewed
Sep 9, 2023
| // In the meantime we can silence this clippy suggestion since the vtable is | ||
| // benign in this case anyway: | ||
| // https://github.com/rust-lang/rust-clippy/issues/6524 | ||
| #[allow(clippy::vtable_address_comparisons)] |
There was a problem hiding this comment.
You can drop this now, the fix seems to have landed in 1.72 😬
There was a problem hiding this comment.
heh, small world.
thanks for the update.
There was a problem hiding this comment.
Thank you for backlinking the whole thing, I ran into this for an unrelated (non-Android 😉) project and wouldn't have otherwise found that it was addressed in Rust 1.72 without existing clippy issues being updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a clippy warning about Arc::ptr_eq potentially comparing vtable meta data associated with wide pointers there was a recent change to explicitly only check the address pointers and discard any wide pointer meta data.
The Rust libs team has since resolved to update Arc::ptr_eq so that it doesn't compare meta data for the wrapped value (such as a dyn trait vtable):
rust-lang/rust#103763
In the meantime we can silence this clippy suggestion since the vtable is benign in this case anyway:
rust-lang/rust-clippy#6524
Fixes: #26