Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert recent change to avoid using Arc:ptr_eq #29

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Revert recent change to avoid using Arc:ptr_eq #29

merged 1 commit into from
Dec 20, 2022

Commits on Dec 20, 2022

  1. Revert recent change to avoid using Arc:ptr_eq 

    Due to a clippy warning about Arc::ptr_eq potentially comparing
vtable meta data associated with wide pointers there was a recent
change to explicitly only check the address pointers and discard
any wide pointer meta data.

The Rust libs team has since resolved to update Arc::ptr_eq so that it
doesn't compare meta data for the wrapped value (such as a dyn trait
vtable):
rust-lang/rust#103763

In the meantime we can silence this clippy suggestion since the vtable
is benign in this case anyway:
rust-lang/rust-clippy#6524
    Robert Bragg committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    86dd933 View commit details
    Browse the repository at this point in the history